-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zope interface 5.1.x fieldset problem #253
Fix zope interface 5.1.x fieldset problem #253
Conversation
Update: this PR now contains a fix. Problem was that the I have temporarily changed Travis to test on 5.2.2 and 5.2.3-pending, so we test both old and new zope.interface. Works locally. I guess it will work on 5.0 and 5.1 as well, but Travis will tell us. |
On those versions, pin check-manifest to 0.44 to prevent getting version conflicts for `build`, `pep517` and `virtualenv`. We want to test with newer and older zope.interface versions, for #252 5.2.x is currently 5.2.2, with zope.interface 5.0.2. 5.2.3-pending has zope.interface 5.1.2. This will fail once 5.2.3-pending is out of pending, but that is just a signal that I can clean this Travis config up again.
They pass now on Plone 5.2.2 and 5.2.3 with Python 3.8.
7e5a448
to
a04596e
Compare
The tests on Plone 5.2.3 failed because it has a newer Products.MailHost, which means messages are bytes, not text. I updated the tests for that. No changes in real code needed.
|
Updated check-manifest too. It depends on 'build', added that too. I ran into version conflicts with the easyform buildout, see collective/collective.easyform#253
The Travis links show as 'pending', but when you follow those links, you will see the build is green. |
No reaction after almost a week. This package is not a reviewer-rich environment. ;-) |
See issue #252.
This does not fix anything, but it should show the errors on Travis.